quick/netradiant-custom
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

* fix decompilation of brushes with edge case face normal ( -0.577350259 -0.577350259 0.577350259 ) and MakeNormalVectors() in general

Browse Source
This commit is contained in:
Garux 2021-10-14 14:33:44 +03:00
parent bc7bd516e6
commit 5283b70a83
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tools/quake3/common/qmath.h
View File

@ -263,14 +263,21 @@ inline void ComputeAxisBase( const BasicVector3<Element>& normal, BasicVector3<O
================ ================
*/ */
inline void MakeNormalVectors( const Vector3& forward, Vector3& right, Vector3& up ){ inline void MakeNormalVectors( const Vector3& forward, Vector3& right, Vector3& up ){
#if 0
// this rotate and negate guarantees a vector // this rotate and negate guarantees a vector
// not colinear with the original // not colinear with the original
//! fails with forward( -0.577350259 -0.577350259 0.577350259 )
//! colinear right( 0.577350259 0.577350259 -0.577350259 )
right[1] = -forward[0]; right[1] = -forward[0];
right[2] = forward[1]; right[2] = forward[1];
right[0] = forward[2]; right[0] = forward[2];
right = VectorNormalized( right - forward * vector3_dot( right, forward ) ); right = VectorNormalized( right - forward * vector3_dot( right, forward ) );
up = vector3_cross( right, forward ); up = vector3_cross( right, forward );
#else
right = VectorNormalized( vector3_cross( g_vector3_axes[ vector3_min_abs_component_index( forward ) ], forward ) );
up = vector3_cross( right, forward );
#endif
} }