quick/netradiant-custom
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sanitize Entity inspector key/value input

Browse Source
This commit is contained in:
Garux 2023-01-10 00:15:08 +06:00
parent 2ed868d254
commit 0ac6b342d8
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
radiant/entityinspector.cpp
View File

@ -1048,11 +1048,18 @@ void EntityInspector_applyKeyValue(){
// return; // return;
// } // }
// RR2DO2: we don't want spaces in entity keys // RR2DO2: we don't want spaces and special symbols in entity keys
if ( strstr( key.constData(), " " ) ) { if ( std::any_of( key.cbegin(), key.cend(), []( const char c ){ return strchr( " \n\r\t\v\"", c ) != nullptr; } ) ) {
qt_MessageBox( g_entityKeyEntry->window(), "No spaces are allowed in entity key names." ); qt_MessageBox( g_entityKeyEntry->window(), "No spaces, newlines, tabs, quotes are allowed in entity key names." );
return; return;
} }
if ( std::any_of( value.cbegin(), value.cend(), []( const char c ){ return strchr( "\n\r\"", c ) != nullptr; } ) ) {
qt_MessageBox( g_entityKeyEntry->window(), "No newlines & quotes are allowed in entity key values." );
return;
}
// avoid empty key name; empty value is okay: deletes key
if( key.isEmpty() )
return;
if ( string_equal( key.constData(), "classname" ) ) { if ( string_equal( key.constData(), "classname" ) ) {
Scene_EntitySetClassname_Selected( value.constData() ); Scene_EntitySetClassname_Selected( value.constData() );